Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I also ported it to use malloc instead of treating the heap as a single giant array, though a quick look suggests they did it rather more competently (though admittedly given my C code that's really not a high bar to clear).

I suspect that once I untangle my somewhat hacky version of that the remainder of my patches will apply just fine but there'll still be at least a bit of mental effort involved.



Do you have a summary of those changes or a repo up anywhere? If they are general-purpose you might consider sending a PR upstream to n-t-roff


A little late replying here, sorry.

Probably nothing that interesting - the malloc stuff was the big change and n-t-roff already did a much better job of it than I did.

But if there's anything in the remaining stack once I've backed it out that seems useful I'll be sure to PR it - even if it doesn't make it in to mainline it seems as good a way to memorialise the patch for other people's use as anything else.

(the repo is currently private because gritter had politely requested nobody make it work on windows and one of my patches worked around a cygwin bug - given the advent of WSL I doubt anybody would want that one anyway so I expect to let it be lost to time along with the half-arsed malloc code)


It will be nice to see your efforts publicly.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: