Hacker Newsnew | past | comments | ask | show | jobs | submit | tonghohin's commentslogin

Thanks! I usually use the OSM API for that: https://nominatim.org/release-docs/develop/api/Search/. But if you need more accurate data, you may wanna use the Google Maps API.


Thank you! I will give it a try with Nominatim and see what I can cook with it.


Well, I can't even use it at all, it's just stuck on the 'Setting Up Your Account' step forever. That's a pretty sad product launch lol.


Thanks for the idea! I just made that feature!


Just deployed a new feature, audio can also be shared now! But it's only supported in Chrome and Edge, and users must select the option to share a tab. It won't work for sharing a window or whole screen.


No, it doesn't share across domains.


It should work, is it not working for you?


I guess you visited the page right after a new deployment. This happens sometimes due to a version mismatch in Next.js after deployment. Refreshing the page should fix it!


Yeah, it's not working that well on phones right now, working on it...


I just fixed that, the share button should stay forever now until you click it.


No, it's not using TURN server now.


> No, it's not using TURN server now.

You state it uses PeerJS. And indeed, the code calls from PeerJS,

  const peer = new Peer();
(https://github.com/tonghohin/screen-sharing/blob/18f6ab93716...)

I.e., it constructs a PeerJS Peer without manually specifying PeerOptions. That class, in turn, states,

  /**
   * Configuration hash passed to RTCPeerConnection.
   * This hash contains any custom ICE/TURN server configuration.
   *
   * Defaults to {@apilink util.defaultConfig}
   */
  config?: any;
Since we're not overriding it, we take the default. And `defaultConfig` leads us to: https://github.com/peers/peerjs/blob/c073252f879b57757f8a82d... which lists STUN & TURN servers.

… so it sure looks to me like it is using a TURN server…


Sorry for the misleading wording, I was trying to say that I'm not paying for any TURN servers. You are totally right, PeerJS is still using TURN server under the hood. Thanks for pointing that out!


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: